Add back get_url_logout in auth managers but make it optional#47729
Merged
vincbeck merged 1 commit intoapache:mainfrom Mar 13, 2025
Merged
Add back get_url_logout in auth managers but make it optional#47729vincbeck merged 1 commit intoapache:mainfrom
get_url_logout in auth managers but make it optional#47729vincbeck merged 1 commit intoapache:mainfrom
Conversation
potiuk
approved these changes
Mar 13, 2025
Contributor
Author
|
Error unrelated to the PR. Merging |
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
This was referenced Apr 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #47725, we realized we actually needed the method
get_url_logoutfrom auth managers. This would give an option to auth manage to provide a route where they can invalide resources such as a session. Make it optional because not all auth managers need this.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.